tedwards/realms-in-ruin-dev
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Document Batch 4A Pass 8 animation archaeology: AnimNotify callbacks and ability cleanup wiring.

Browse Source 
Resolves UseAbility* callers via shared AN_Ability notifies, qualifies Pass 6 ability statuses, and records AnimBP/Montage dependencies without modifying Unreal assets.

Co-authored-by: Cursor <cursoragent@cursor.com>
This commit is contained in:
tedwards
2026-07-16 21:00:59 -07:00
co-authored by Cursor
parent 0d045d142f
commit 4e926d1ccc
6 changed files with 327 additions and 334 deletions
Download Patch File Download Diff File Expand all files Collapse all files
Documentation/Archaeology/15-HandoffStatus.md
+62 -98
View File
@@ -5,16 +5,16 @@
- **Scope:** Authoritative cross-model continuation document for Phase 1.
- **Last updated:** 2026-07-16
- **Current phase:** Phase 1 — Static Architecture
- **Last completed pass / batch:** Batch 3 (Pass 6)
- **Next authorized work:** Wait for user — recommend **Batch 4** (Pass 4 sessions / Pass 7 GAS / Pass 8 animation — only as authorized)
- **Last completed pass / batch:** Batch 4A (Pass 8)
- **Next authorized work:** Wait for user — recommend **Pass 7** (GAS) or remaining Batch 4 passes as separately authorized
## Phase completed
| Item | Value |
|------|--------|
| Phase | Phase 1 — Static Architecture (in progress) |
| Batch completed | Batch 3 — Per-character ability archaeology |
| Passes completed | Pass 6 (Paladin → Amazonian → Cleric → Wizard → Gunslinger) |
| Batch completed | Batch 4A — Animation dependencies and ability callbacks |
| Passes completed | Pass 8 |
| Date completed | 2026-07-16 |
| Model identifier | Cursor Grok 4.5 |
@@ -22,150 +22,114 @@
## Repository integrity
### Starting state (Batch 3)
### Starting state (Batch 4A)
- **Git:** Dirty with expected Batch 2 Archaeology Markdown only (not unexpected):
- Modified: `03`, `06`, `08`, `09`, `11`, `13`, `14`, `15`
- Untracked: `05-LegacyAbilityArchitecture.md`
- **Baseline commit:** `ff5640a0` Establish UE 5.8 known-good baseline with Batch 1 archaeology docs.
- **Git:** Clean (`git status --short` empty; diffs empty).
- **Baseline commits:** `ff5640a0` Batch 1; `0d045d14` Batch 2–3 archaeology.
- **Authorization:** Batch 1–3 docs committed; `01-Phase-1-Plan.md` resolved as `00A-Phase-1-Execution-Plan.md` (committed).
- **Editor:** `IsPIERunning=false`; level `/Game/_Main/Levels/Testing/Test01`; selected actor `BP_Enemy_Skeleton_C_1`.
### Ending state (Batch 3 close)
### Ending state (Batch 4A close)
- Modified/created files: Markdown only under `Documentation/Archaeology/` (listed below).
- **Unexpected untracked file reported (not reverted):** `Documentation/Archaeology/01-Phase-1-Plan.md` — present at close; not created by Pass 6 doc writes; contents not inspected this closeout.
- Modified files: Markdown only under `Documentation/Archaeology/` (listed below).
- No source, config, plugin, map, or Unreal asset writes.
- PIE not started; level and selection not changed intentionally.
- Ending Git check: only Archaeology Markdown dirty (confirm at close).
- PIE not started; level and selection unchanged.
- Ending Git: only authorized Archaeology Markdown dirty.
---
## Areas fully inspected (Batch 3 tools)
## Areas fully inspected (Batch 4A)
- Player_Paladin: Ability 001–004 Begin/End/UseAbility/Charge/ChargeBox connected paths
- Player_Amazonian: Ability 001 + UseAbility001 + ReceiveAnyDamage; 002–004 absence
- Player_Cleric: Ability 001–004 + ConcentrateHandle/EndConcentrate + UseAbility002/004
- Player_Wizard: EventGraph walk; alternate UseAbility/input/spell search; unwired assets
- Player_Gunslinger: IsDataOnly confirmation; Parent-only EventGraph; inherited stubs
- ABP_Paladin / ABP_Amazon / ABP_Cleric / ABP_Wizard structure and EventGraph ability-related reads
- Paladin / Amazonian / Cleric ability Montages via dependency → AnimNotify BP chains
- `AN_Ability_001–004`, `AN_AttackComplete` Received_Notify bodies
- Wizard animation folder (ABP only; no montages)
- Gunslinger deps (no AnimBP)
- Pass 6 status qualification / reclassification table
## Areas partially inspected
- FCanUseMana function body (call sites only)
- Client_Charge / ChargeTimeline numeric curve details
- PlayerHitCheck graphs (existence known; full absorb logic → later)
- Montage notify tracks (seeded in doc 10 → Pass 8)
- Montage section names, blend, root motion, notify times (tool limits)
- AnimGraph transition rule DSL (Paladin reconstructed via VariableGet; others partial)
- `Cleric_Ability003` non-montage asset referencing AN_AttackComplete (identity only)
## Areas not yet inspected
- Frontend/session flows (Batch 4 Pass 4)
- GE/cue systemwide inventory (Batch 4 Pass 7)
- Animation deep dive / AnimNotify → UseAbility (Batch 4 Pass 8)
- Enemy BP AI deep dive (Batch 4 Pass 9)
- Full UI trees / pickups (Batch 4)
- Cross-character migration matrix doc 07 (Pass 11)
- Pass 7 GE/cue/tag inventory
- Pass 4 frontend/sessions
- Pass 9 enemy BP AI
- Pass 10 pickups/UI trees
- Pass 11 migration matrix
- PIE / runtime
---
## Blueprints inspected
## Animation assets inspected
| Asset | Depth |
|-------|--------|
| BP_PlayerCharacterBase | Correlation only (Batch 2 deep dive stands) |
| Player_Paladin | Pass 6 full ability path reconstruction |
| Player_Amazonian | Pass 6 full ability path reconstruction |
| Player_Cleric | Pass 6 full ability path reconstruction |
| Player_Wizard | Pass 6 ability + alternate path search |
| Player_Gunslinger | Pass 6 data-only / inherited stub confirmation |
Referenced when required for ability identity: montage paths, MagicSpell_01_Cue, BP_PlayerProjectile (unwired), GE_* DefaultAttributes (orphans), NS_Wizard_Ability001 (unwired).
## C++ classes inspected
None new this batch (Batch 1 inventory stands).
## Assets / configs inspected
Unreal content via MCP read-only only. No config file writes.
| ABP_Paladin, ABP_Amazon, ABP_Cleric, ABP_Wizard | Graphs, variables, EventGraph DSL where available |
| Attack_*_Fast_Montage (Paladin); Paladin_Ability004_Montage | Deps → notifies |
| A_Hu_F_Combat_2H_Attack* (Amazon) | Deps → notifies |
| Cleric_PrimaryAttack_*; Cleric_Ability002/003/004_Montage | Deps → notifies |
| AN_Ability_001–004, AN_AttackComplete | Received_Notify DSL / bodies |
| Cleric_Hu_M_Spell_Staff_Up_Impact_Montage | Referencers = [] |
## Files created
| File | Status |
|------|--------|
| Documentation/Archaeology/10-AnimationDependencies.md | Draft |
None new (updated existing `10`).
## Files updated
| File | Status |
|------|--------|
| Documentation/Archaeology/05-LegacyAbilityArchitecture.md | Draft (major Pass 6 rewrite) |
| Documentation/Archaeology/06-PartialGASArchitecture.md | Draft |
| Documentation/Archaeology/10-AnimationDependencies.md | Draft (Pass 8 rewrite) |
| Documentation/Archaeology/05-LegacyAbilityArchitecture.md | Draft |
| Documentation/Archaeology/08-CharacterSystems.md | Draft |
| Documentation/Archaeology/13-Unknowns-And-RuntimeQuestions.md | Draft |
| Documentation/Archaeology/14-EvidenceIndex.md | Draft |
| Documentation/Archaeology/15-HandoffStatus.md | Draft |
**03-ClassHierarchy.md not modified** (no Batch 2 structural correction required).
**00-MCP-Capability-Calibration.md not modified.**
**07-AbilityMigrationMatrix.md not created** (Pass 11).
**06 not modified** (no new connected GAS interactions).
**07 not created.**
## Toolsets used
EditorAppToolset (IsPIERunning, GetSelectedActors); SceneTools (get_current_level); AssetTools (class/tags/deps/refs); BlueprintTools (graphs/events/functions/variables/find_nodes/get_node_infos/get_connected_subgraph/read_graph_dsl); ObjectTools (get_properties).
EditorAppToolset; SceneTools; AssetTools; BlueprintTools; ObjectTools (limited). Subagents for Paladin/Amazonian/Cleric deep walks.
## Tool limitations / failed queries
- CustomEvent Reliable/Unreliable flags: **Unknown — MCP property visibility limitation**
- `find_nodes(title="Comment")` returned [] — comment-box regions Unknown
- SemanticSearch unavailable
- Some CallMcpTool invocations initially failed when `server`/`toolName` wrapper omitted; retried successfully
- Blocked read-only continuity queries (if any): recorded as tool limitation, not mutation
- Montage `Notifies` property unreadable
- Asset-registry `AnimNotifyList` empty for BP notify classes
- `read_graph_dsl` empty on AnimGraph/state/transition graphs
- `AssetTools.get_class` Unknown tool (used tags)
- Some CallMcpTool batches failed schema intermittently; retried
- Notify trigger times: Unknown — Tool Limitation
## Contradictory evidence
## Key Pass 8 outcomes
1. Dual HUD: native ASC Overlay vs DEPRECATED float UpdatePlayerHUD — both active statically.
2. DefaultAttributes: GE assets exist (incl. character orphans); BP_PlayerState=None; C++ never applies.
3. Enemy ASC ownership vs GetASC PlayerState path — unchanged from Batch 1.
4. Cleric Ability 004: FCanUseMana executed but Branch uses literal true — structural defect.
## Unresolved naming ambiguities
- Amazon vs Amazonian GE folder naming (Pass 7)
- WBP_PlayerHUD naming — resolved class-wise; name still misleading
## Requires Manual Editor Inspection
- CustomEvent Reliable/Unreliable flags
- DEPRECATED comment-box visual boundaries
- Montage notify tracks → UseAbility*
## Requires Runtime Inspection / PIE
- Dual HUD behavior
- Default attribute spawn values
- Enemy GetASC impact
- Cleric Ability 004 / Wizard BeginPlay Parent skip
- Ability networking feel / reliability
1. **UseAbility* callers resolved** — AnimNotify BPs, not AnimBP graphs.
2. **Cleanup** for notify-driven attacks — `AN_AttackComplete` → `SetIsAttacking`.
3. **Cleric 001/003 notifies dead** — interface unimplemented.
4. **Pass 6 primary statuses unchanged**; qualifications recorded in `10` reclassification table.
5. **Static networking risk** — Multicast montage notify evaluation required for hit windows.
## Suggested next bounded task
**Authorize Batch 4 only** (choose one or more Passes explicitly):
**Authorize explicitly one of:**
1. Pass 7 — GAS GE/cue/tag inventory
2. Pass 8 — Animation / AnimNotify → UseAbility wiring
3. Pass 4 — Frontend / session flows
4. Pass 9 — Enemy BP AI
2. Pass 9 — Enemy BP AI
3. Pass 4 — Frontend / sessions
**Do not begin** Pass 11 migration matrix or PIE until authorized.
**Do not begin** Pass 11 or PIE until authorized.
**Exact starting files for next model:**
- Read: `00`, `05`, `06`, `08`, `10`, `13`, `14`, `15`
- For Pass 7: start GE assets under `/Game/_Main/` + ASC defaults
- For Pass 8: start montages listed in `10-AnimationDependencies.md`
**Starting files:** `00`, `05`, `06`, `08`, `10`, `13`, `14`, `15`.
## Confirmation
- No Unreal assets modified
- No source/config/map/plugin modified
- No editor state intentionally modified (PIE not started; level/selection unchanged)
- No work beyond Pass 6 performed
- Waiting for explicit authorization before Batch 4
- No editor state intentionally modified
- No work beyond Pass 8 performed
- Waiting for explicit authorization before Pass 7 or other Batch 4 passes